Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PaddlePaddle Hackathon] 第53题 #1114

Merged
merged 15 commits into from
Oct 28, 2021
Merged

[PaddlePaddle Hackathon] 第53题 #1114

merged 15 commits into from
Oct 28, 2021

Conversation

iverxin
Copy link
Contributor

@iverxin iverxin commented Oct 3, 2021

PR types

New features

PR changes

Models

Description

#1077

  1. 在PaddleNLP的BigBird模型代码中，新增 BigBirdForQuestionAnswering，BigBirdForTokenClassification，BigBirdForMultipleChoice，BigBirdForCausalLM 和 BigBirdForMaskedLM 这五个类。
  2. 包含项目代码、注释、单测文件

@CLAassistant
Copy link

CLAassistant commented Oct 3, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@iverxin iverxin mentioned this pull request Oct 3, 2021
Closed
@ZeyuChen ZeyuChen requested a review from yingyibiao October 8, 2021 14:18
@ZeyuChen ZeyuChen requested a review from joey12300 October 8, 2021 14:19
joey12300
joey12300 reviewed Oct 9, 2021
View reviewed changes
Copy link
Contributor

@joey12300 joey12300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

麻烦按照review意见修改代码

paddlenlp/transformers/bigbird/modeling.py Outdated Show resolved Hide resolved
paddlenlp/transformers/bigbird/modeling.py Show resolved Hide resolved
paddlenlp/transformers/bigbird/modeling.py Outdated Show resolved Hide resolved
paddlenlp/transformers/bigbird/modeling.py Show resolved Hide resolved
@yingyibiao
Copy link
Contributor

https://github.com/PaddlePaddle/PaddleNLP/blob/develop/docs/model_zoo/transformers.rst
这个文件也需要同步修改

@iverxin
Copy link
Contributor Author

iverxin commented Oct 20, 2021

https://github.com/PaddlePaddle/PaddleNLP/blob/develop/docs/model_zoo/transformers.rst 这个文件也需要同步修改

您好，在这个pr里没有增加预训练模型，看样子不需要修改这个文件。

@yingyibiao
Copy link
Contributor

https://github.com/PaddlePaddle/PaddleNLP/blob/develop/docs/model_zoo/transformers.rst 这个文件也需要同步修改

您好，在这个pr里没有增加预训练模型，看样子不需要修改这个文件。

image
这个表格需要填写一下哈～

@iverxin
Copy link
Contributor Author

iverxin commented Oct 20, 2021

https://github.com/PaddlePaddle/PaddleNLP/blob/develop/docs/model_zoo/transformers.rst 这个文件也需要同步修改

您好，在这个pr里没有增加预训练模型，看样子不需要修改这个文件。

image 这个表格需要填写一下哈～

Done~

yingyibiao
yingyibiao reviewed Oct 20, 2021
View reviewed changes
Copy link
Contributor

@yingyibiao yingyibiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for transformers.rst file

@yingyibiao yingyibiao requested a review from joey12300 October 26, 2021 09:10
joey12300
joey12300 approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@joey12300 joey12300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yingyibiao yingyibiao merged commit d07e237 into PaddlePaddle:develop Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yingyibiao yingyibiao yingyibiao left review comments

@joey12300 joey12300 joey12300 approved these changes

Assignees

@guoshengCS guoshengCS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@iverxin @CLAassistant @yingyibiao @joey12300 @ZeyuChen @guoshengCS